Simplify stack tooling and local CCC workflow#24
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request modernizes the project's infrastructure by aligning with standard CCC patterns, removing custom abstractions like SmartTransaction and UdtHandler in favor of native CCC classes. It overhauls the fork management system using pnpm overrides and dedicated scripts, while also deleting extensive legacy planning and research documentation. New SDK unit tests are introduced, and the build process is updated to use tsc. Feedback points out a critical security risk in the forks:bootstrap script's use of curl | bash and suggests pinning the eslint-plugin-react-compiler dependency to improve build stability.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request performs a significant refactoring of the iCKB stack, primarily focusing on removing the deprecated SmartTransaction abstraction, migrating to CCC-native UDT handling, and cleaning up the codebase by removing legacy Lumos dependencies and local utility functions. The changes include deleting deprecated files, updating manager method signatures to use ccc.TransactionLike, and wiring the SDK to use the new IckbUdt implementation. My feedback highlights concerns regarding the removal of .pnpm-store/ from .gitignore, the pinning of the react-compiler version, the simplification of the Vite configuration, and the manual update of the pnpm-workspace.yaml catalog.
|
/gemini review |
phroi
force-pushed
the
cleanup/stack-tooling-series
branch
from
1f3c237 to
d6307bd
Compare
There was a problem hiding this comment.
Code Review
This pull request restructures the monorepo's build and fork management workflows, replacing custom build wrappers with standard TypeScript compilation and introducing a materialization process for local CCC forks. It also cleans up legacy planning documentation and adds utility scripts for environment bootstrapping and validation. Feedback suggests automating the generation of workspace overrides from the configuration source of truth to improve maintainability and reduce manual errors.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request refactors the codebase to remove the deprecated SmartTransaction class and its associated infrastructure, replacing it with native CCC transaction completion patterns. It also centralizes the NervosDAO 64-output limit check into a reusable CCC utility and updates all scattered inline checks to use this new utility. My feedback focuses on improving error handling by suggesting a custom error class for the DAO output limit check, which provides structured context to callers instead of a generic Error.
|
/gemini review |
|
Warning Gemini is experiencing higher than usual traffic and was unable to create the review. Please try again in a few hours by commenting |
|
LGTM Phroi %164 |
1 participant
Why
Changes